McKinlay began his career playing for Dundee United in the Scottish Premier League before moving on to Blackburn Rovers in England in 1995. He then had stints at clubs such as Leicester City, Watford, and Fulham before eventually joining West Ham United in 2015.